Port scala.quoted.runtime.impl.QuoteMatcher #12402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance with #quotes please |
|
test performance with #quotes please |
nicolasstucki
changed the title
|
performance test scheduled: 8 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/12402/ to see the changes. Benchmarks is based on merging with master (f5bfed9) |
|
test performance with #quotes please |
|
performance test scheduled: 3 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/12402/ to see the changes. Benchmarks is based on merging with master (591154d) |
liufengyun
approved these changes
May 13, 2021
| if pat1.isType then matcher.termMatch(scrutinee.asInstanceOf[matcher.qctx.reflect.Term], pat1.asInstanceOf[matcher.qctx.reflect.Term]) | ||
| else matcher.termMatch(scrutinee.asInstanceOf[matcher.qctx.reflect.Term], pat1.asInstanceOf[matcher.qctx.reflect.Term]) | ||
| if pat1.isType then QuoteMatcher.termMatch(scrutinee, pat1)(using ctx1) | ||
| else QuoteMatcher.termMatch(scrutinee, pat1)(using ctx1) |
There was a problem hiding this comment.
This if/else seems not useful -- both branches have the same code.
There was a problem hiding this comment.
Removed unnecessary duplication
liufengyun
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it simpler to maintain and also improves a bit the performace.