Move TreeMap, TreeAccumulator and TreeTraverser into Reflection #10184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
move-tree-map-to-refelction
branch
from
83638bc to
38973e2
Compare
liufengyun
approved these changes
Nov 5, 2020
| trait TreeAccumulator[X] extends reflect.TreeAccumulator[X] { | ||
| val reflect: reflection.type = reflection | ||
| } | ||
| /** TASTy Reflect tree accumulator. |
There was a problem hiding this comment.
I remember one of the previous PRs is to avoid the name TASTy.
Suggested change
| /** TASTy Reflect tree accumulator. | |
| /** Tree accumulator. |
There was a problem hiding this comment.
I'll do a general cleanup of the docs in a separate PR
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 15, 2024
Fixes scala#10184 The overlooked case was an AppliedType where we don't dealias correctly (i.e. at phase at most erasure).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.