-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated inline method does not generate deprecation warning #19913
Comments
2m
added
itype:bug
stat:needs triage
Every issue needs to have an "area" and "itype" label
labels
Mar 11, 2024
fwiw this was too much machinery: The suggestion there was to move CrossVersionChecks earlier. Unused check runs after typer. Or maybe original is available to CrossVersionChecks via "inlined body retainer"; I don't remember how that works. |
nicolasstucki
added
area:inline
and removed
stat:needs triage
Every issue needs to have an "area" and "itype" label
labels
Mar 11, 2024
Moving CrossVersionChecks earlier would not help with transparent inline defs. We probably need to check those just before we inline the calls. |
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this issue
Mar 11, 2024
We must check these constraint just before inlining as later on there on the call might completely disappear. We do the same as we did for experimental definition checks. Fixes scala#19913
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this issue
Mar 11, 2024
We must check these constraint just before inlining as later on there on the call might completely disappear. We do the same as we did for experimental definition checks. Fixes scala#19913
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this issue
Mar 11, 2024
We must check these constraint just before inlining as later on there on the call might completely disappear. We do the same as we did for experimental definition checks. Fixes scala#19913
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this issue
Mar 11, 2024
We must check these constraint just before inlining as later on there on the call might completely disappear. We do the same as we did for experimental definition checks. Fixes scala#19913
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this issue
Mar 19, 2024
We must check these constraint just before inlining as later on there on the call might completely disappear. We do the same as we did for experimental definition checks. Fixes scala#19913
nicolasstucki
added a commit
that referenced
this issue
Mar 19, 2024
We must check these constraint just before inlining as later on there on the call might completely disappear. We do the same as we did for experimental definition checks. Fixes #19913 ### Changes - Define `CrossVersionChecks.checkRef` that checks both deprecation and experimental. - Used in `Inlines` and `PostTyper` to check the deprecation of inlined calls. - Rename `checkDeprecated` to `checkDeprecatedRef` - Move `checkDeprecatedRef` and `skipWarning` to `object CrossVersionChecks`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Compiler version
3.4.0
,3.4.1-RC1
,3.3.3
.Minimized code
Two deprecated methods, one
inline
.Output
Deprecation warning is not shown for the
inline
method.Expectation
Both deprecated methods generate deprecation warnings. This was noticed in Iltotore/iron#229
The text was updated successfully, but these errors were encountered: