Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly Dotty workflow of 2023-12-18 failed #19285

Closed
github-actions bot opened this issue Dec 18, 2023 · 10 comments · Fixed by #19292
Closed

Nightly Dotty workflow of 2023-12-18 failed #19285

github-actions bot opened this issue Dec 18, 2023 · 10 comments · Fixed by #19292

Comments

@github-actions
Copy link
Contributor

See https://github.com/lampepfl/dotty/actions/runs/7243042276

@nicolasstucki
Copy link
Contributor

Error:  Test dotty.tools.dotc.CompilationTests.parallelBackend failed: java.util.concurrent.TimeoutException: Compiling targets timed out, remaining targets: out/parallelBackend/reference, took 1200.005 sec
Error:      at dotty.tools.vulpix.ParallelTesting$Test.executeTestSuite(ParallelTesting.scala:707)

@nicolasstucki
Copy link
Contributor

This was caused by 10f2c10.

@nicolasstucki
Copy link
Contributor

I seems that 10f2c10 was not the cause after all. See #19289 (comment).

@nicolasstucki
Copy link
Contributor

This issue started with 1f7aa24. We need to clean the project to reproduce the issue.

nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Dec 18, 2023
Follow up of scala#19182. Using `fullName` causes the the `parallelBackend`
tests to loop forever.

Fixes scala#19285
Fixes scala#19281
Fixes scala#19278
@nicolasstucki
Copy link
Contributor

This issue is spurious. I am not sure if 1f7aa24 started it anymore. I will need to test this in depth.

@nicolasstucki
Copy link
Contributor

Executing git bisect using

sbt> clean; testOnly dotty.tools.dotc.CompilationTests -- *parallelBackend; testOnly dotty.tools.dotc.CompilationTests -- *parallelBackend; testOnly dotty.tools.dotc.CompilationTests -- *parallelBackend

showed with more confidence that the issue comes from 2dcd64a

nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Dec 18, 2023
This reverts commit 2dcd64a.

This caused the the `parallelBackend` tests to loop forever.

Fixes scala#19285
Fixes scala#19281
Fixes scala#19278
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Dec 18, 2023
This reverts commit 2dcd64a.

This caused the `parallelBackend` tests to loop forever.

Fixes scala#19285
Fixes scala#19281
Fixes scala#19278
@odersky
Copy link
Contributor

odersky commented Dec 18, 2023

I have spurious parallel backend failures in my local runs all the time (maybe one in three runs fails). I suspect a race condition in parallel backend. What is the status of it? Do we run that in production?

@nicolasstucki
Copy link
Contributor

I have spurious parallel backend failures in my local runs all the time (maybe one in three runs fails). I suspect a race condition in parallel backend. What is the status of it? Do we run that in production?

#19290 fixes the issue on the CI. However, we should try to figure out why accessing the symbol of an enum there fails with a race condition.

@odersky
Copy link
Contributor

odersky commented Dec 18, 2023

I can't see how such a commit could make any difference if parallel backend would not have some underlying race problems.

@nicolasstucki
Copy link
Contributor

I assume it is only triggering the issue much more often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment