Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated extension receiver in scaladoc #16647

Closed
prolativ opened this issue Jan 10, 2023 · 0 comments · Fixed by #17097
Closed

Duplicated extension receiver in scaladoc #16647

prolativ opened this issue Jan 10, 2023 · 0 comments · Fixed by #17097

Comments

@prolativ
Copy link
Contributor

Compiler version

3.3.0-RC1-bin-20230109-f56089b-NIGHTLY

Minimized code

package test

trait Ctx

object Ops:
  extension (i: Int)
    def foo() = i + 1
  extension (using Ctx)(i: Int)
    def bar() = i + 2
  extension (i: Int)(using Ctx)
    def baz() = i + 3

Output

Screenshot 2023-01-10 at 11 34 06

Expectation

The first (i: Int) in the signature of each extension should not be there

@Kordyjan Kordyjan added this to the Future versions milestone Jan 13, 2023
KacperFKorban added a commit that referenced this issue Mar 15, 2023
…7097)

When generating Scaladoc, a duplicate of the parameter appears at the
beginning of each signature.
The solution here was to remove this line, as the parameter is already
present in the argsSig value.

Before :
<img width="300" alt="Screenshot 2023-03-13 at 15 25 43"
src="https://user-images.githubusercontent.com/44496264/224735195-8ff3f79a-83d9-4fa0-a5af-99da5aa30b9c.png">

After :
<img width="300" alt="Screenshot 2023-03-13 at 15 24 05"
src="https://user-images.githubusercontent.com/44496264/224735171-3eb67419-8b98-499e-a180-58202b54826b.png">

I didn't do a test because I don't think there is one (or I couldn't
find it). But if needed, a next PR or a next commit to add them can be
done.

Fixes: #16647
@Kordyjan Kordyjan modified the milestones: Future versions, 3.3.1 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants