Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No summary feature warning under sbt #14576

Closed
som-snytt opened this issue Feb 27, 2022 · 1 comment · Fixed by #14602
Closed

No summary feature warning under sbt #14576

som-snytt opened this issue Feb 27, 2022 · 1 comment · Fixed by #14602
Assignees
Labels
area:reporting Error reporting including formatting, implicit suggestions, etc area:sbt-bridge itype:bug
Milestone

Comments

@som-snytt
Copy link
Contributor

Compiler version

3.1.1

Minimized code

Observed on forum which links to a trivial project that incurs a feature warning.

Output

[success] Total time: 1 s, completed Feb 27, 2022, 1:44:03 PM

under -feature

[warn] -- Feature Warning: /home/.../test-scala3/src/main/scala/p/Writer.scala:5:15
[warn] 5 |  implicit def cv(t: T): String = t.toString
[warn]   |               ^
[warn]   |Definition of implicit conversion method cv should be enabled
[warn]   |by adding the import clause 'import scala.language.implicitConversions'
[warn]   |or by setting the compiler option -language:implicitConversions.
[warn]   |See the Scala docs for value scala.language.implicitConversions for a discussion
[warn]   |why the feature should be explicitly enabled.
[warn] one warning found
[warn] one warning found
[success] Total time: 0 s, completed Feb 27, 2022, 1:46:29 PM

Expectation

[warn] 1 feature warning; re-run with -feature for details
[warn] one warning found
[success] Total time: 2 s, completed Feb 27, 2022, 1:40:48 PM

as in Scala 2.

The doubled output [warn] one warning found is also suspicious.

Summary is correct from command line:

✗ scalac -source:future -d /tmp $(finds)
there were 2 feature warning(s); re-run with -feature for details
@som-snytt som-snytt added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Feb 27, 2022
@griggt
Copy link
Contributor

griggt commented Feb 27, 2022

The doubled output [warn] one warning found is also suspicious.

This doubled output has already been fixed in 3.1.2-RC1 by #13843

@griggt griggt added area:sbt-bridge and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Feb 27, 2022
@griggt griggt self-assigned this Mar 2, 2022
@griggt griggt added the area:reporting Error reporting including formatting, implicit suggestions, etc label Mar 2, 2022
griggt added a commit that referenced this issue Mar 3, 2022
Fix #14576: Ensure unreported warning summaries are also emitted via sbt-bridge
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:reporting Error reporting including formatting, implicit suggestions, etc area:sbt-bridge itype:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants