-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completion of back-ticked members does not give backticks in REPL #14006
Comments
This seems related to #13369 |
Just to tie these together this also seems a duplicate of #4406. I have a working POC locally But I'm still trying to fix some issues that were also noticed in #13369 when you are trying to start the completion with a backtick for example you end up getting your completion, but it then begins with two backticks, so I need to figure that out. Looks like this was also hit on in #11794. All that to say, I'm working on this. |
They might have one of the old contributor's t-shirts lying around for you, that says:
|
This PR adds in the functionality to add in backticks when needed when giving back completions and also correctly returning completions when the user has already started typing a backtick. Fixes: scala#4406, scala#14006
This PR adds in the functionality to add in backticks when needed when giving back completions and also correctly returning completions when the user has already started typing a backtick. Fixes: scala#4406, scala#14006
Compiler version
3.1.0
Minimized code and output
Expectation
The completion of back-ticked names should be wrapped into back-ticks so that the code works. A beginner might not know the rules of an identifier and a back-ticked member not following the rules is silently showing up in the list of completions. This may cause confusion.
It would also be nice if completion worked also after typing a back-tick.
The text was updated successfully, but these errors were encountered: