Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect highlight for type constructor in REPL #11202

Closed
izhangzhihao opened this issue Jan 24, 2021 · 0 comments · Fixed by #14518
Closed

Incorrect highlight for type constructor in REPL #11202

izhangzhihao opened this issue Jan 24, 2021 · 0 comments · Fixed by #14518
Labels
area:repl itype:bug Spree Suitable for a future Spree
Milestone
3.1.3

Comments

@izhangzhihao
Copy link
Contributor

Compiler version

scalac -version
Scala compiler version 3.0.0-M3 -- Copyright 2002-2020, LAMP/EPFL

Minimized code

type Id[A] = A

Output

image

But, if I type:

type Id[A]

it just works fine:

image

Expectation

Correctly highlighted.

It may be related to #3814 #3987
@dwijnand dwijnand added the Spree Suitable for a future Spree label Nov 30, 2021
ckipp01 added a commit to ckipp01/dotty that referenced this issue Feb 19, 2022
@ckipp01
fix(scala#11202): special case LambdaTypeTree in syntax highlighting
23a9c39 
This fixes scala#11202 and ensures that when a LambdaTypeTree is encountered
we are only highlighting the actual type params.
@ckipp01 ckipp01 mentioned this issue Feb 19, 2022
Merged
ckipp01 added a commit to ckipp01/dotty that referenced this issue Feb 19, 2022
@ckipp01
fix(scala#11202): explicitly handle TypeTree in syntax highlighting
82ae5cc
ckipp01 added a commit to ckipp01/dotty that referenced this issue Feb 19, 2022
@ckipp01
fix(scala#11202): explicitly handle TypeTree in syntax highlighting
b1e4267
smarter added a commit that referenced this issue Feb 19, 2022
@smarter
Merge pull request #14518 from ckipp01/lambdaTypeTreeHighlighting
4f3d767 
fix(#11202): special case type trees in syntax highlighting
olsdavis pushed a commit to olsdavis/dotty that referenced this issue Apr 4, 2022
@ckipp01 @olsdavis
fix(scala#11202): explicitly handle TypeTree in syntax highlighting
1253563
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:repl itype:bug Spree Suitable for a future Spree
Projects
None yet
Milestone
3.1.3
Development

Successfully merging a pull request may close this issue.

fix(#11202): special case type trees in syntax highlighting ckipp01/dotty
4 participants
@dwijnand @nicolasstucki @Kordyjan @izhangzhihao