Merge pull request #11768 from dotty-staging/fix-11178

Fix #11178: remove unsound tweak for F-bounds in isInstanceOf check

compiler/src/dotty/tools/dotc/core/PatternTypeConstrainer.scala

@@ -73,7 +73,7 @@ trait PatternTypeConstrainer { self: TypeComparer =>
    *  scrutinee and pattern types. This does not apply if the pattern type is only applied to type variables,
    *  in which case the subtyping relationship "heals" the type.
    */
-  def constrainPatternType(pat: Type, scrut: Type): Boolean = trace(i"constrainPatternType($scrut, $pat)", gadts) {
+  def constrainPatternType(pat: Type, scrut: Type, widenParams: Boolean = true): Boolean = trace(i"constrainPatternType($scrut, $pat)", gadts) {
 
     def classesMayBeCompatible: Boolean = {
       import Flags._
@@ -135,7 +135,7 @@ trait PatternTypeConstrainer { self: TypeComparer =>
             case _ => NoType
           }
           if (upcasted.exists)
-            constrainSimplePatternType(pat, upcasted) || constrainUpcasted(upcasted)
+            constrainSimplePatternType(pat, upcasted, widenParams) || constrainUpcasted(upcasted)
           else true
       }
     }
@@ -155,7 +155,7 @@ trait PatternTypeConstrainer { self: TypeComparer =>
         case pat: RefinedOrRecType =>
           constrainPatternType(stripRefinement(pat), scrut)
         case pat =>
-          constrainSimplePatternType(pat, scrut) || classesMayBeCompatible && constrainUpcasted(scrut)
+          constrainSimplePatternType(pat, scrut, widenParams) || classesMayBeCompatible && constrainUpcasted(scrut)
       }
     }
   }
@@ -194,7 +194,7 @@ trait PatternTypeConstrainer { self: TypeComparer =>
    *  case classes without also appropriately extending the relevant case class
    *  (see `RefChecks#checkCaseClassInheritanceInvariant`).
    */
-  def constrainSimplePatternType(patternTp: Type, scrutineeTp: Type): Boolean = {
+  def constrainSimplePatternType(patternTp: Type, scrutineeTp: Type, widenParams: Boolean): Boolean = {
     def refinementIsInvariant(tp: Type): Boolean = tp match {
       case tp: ClassInfo => tp.cls.is(Final) || tp.cls.is(Case)
       case tp: TypeProxy => refinementIsInvariant(tp.underlying)
@@ -213,7 +213,8 @@ trait PatternTypeConstrainer { self: TypeComparer =>
 
     val widePt =
       if migrateTo3 || refinementIsInvariant(patternTp) then scrutineeTp
-      else widenVariantParams(scrutineeTp)
+      else if widenParams then widenVariantParams(scrutineeTp)
+      else scrutineeTp
     val narrowTp = SkolemType(patternTp)
     trace(i"constraining simple pattern type $narrowTp <:< $widePt", gadts, res => s"$res\ngadt = ${ctx.gadt.debugBoundsDescription}") {
       isSubType(narrowTp, widePt)

compiler/src/dotty/tools/dotc/core/TypeComparer.scala

@@ -2687,8 +2687,8 @@ object TypeComparer {
   def dropTransparentTraits(tp: Type, bound: Type)(using Context): Type =
     comparing(_.dropTransparentTraits(tp, bound))
 
-  def constrainPatternType(pat: Type, scrut: Type)(using Context): Boolean =
-    comparing(_.constrainPatternType(pat, scrut))
+  def constrainPatternType(pat: Type, scrut: Type, widenParams: Boolean = true)(using Context): Boolean =
+    comparing(_.constrainPatternType(pat, scrut, widenParams))
 
   def explained[T](op: ExplainingTypeComparer => T, header: String = "Subtype trace:")(using Context): String =
     comparing(_.explained(op, header))

compiler/src/dotty/tools/dotc/transform/TypeTestsCasts.scala

@@ -34,10 +34,6 @@ object TypeTestsCasts {
    *
    *  First do the following substitution:
    *  (a) replace `T @unchecked` and pattern binder types (e.g., `_$1`) in P with WildcardType
-   *  (b) replace pattern binder types (e.g., `_$1`) in X:
-   *      - variance = 1  : hiBound
-   *      - variance = -1 : loBound
-   *      - variance = 0  : OrType(Any, Nothing) // TODO: use original type param bounds
    *
    *  Then check:
    *
@@ -67,29 +63,6 @@ object TypeTestsCasts {
       }
     }.apply(tp)
 
-    def replaceX(tp: Type)(using Context) = new TypeMap {
-      def apply(tp: Type) = tp match {
-        case tref: TypeRef if tref.typeSymbol.isPatternBound =>
-          if (variance == 1) tref.info.hiBound
-          else if (variance == -1) tref.info.loBound
-          else OrType(defn.AnyType, defn.NothingType, soft = true) // TODO: what does this line do?
-        case _ => mapOver(tp)
-      }
-    }.apply(tp)
-
-    /** Approximate type parameters depending on variance */
-    def stripTypeParam(tp: Type)(using Context) = new ApproximatingTypeMap {
-      val boundTypeParams = util.HashMap[TypeRef, TypeVar]()
-      def apply(tp: Type): Type = tp match {
-        case _: MatchType =>
-          tp // break cycles
-        case tp: TypeRef if !tp.symbol.isClass =>
-          boundTypeParams.getOrElseUpdate(tp, newTypeVar(tp.underlying.toBounds))
-        case _ =>
-          mapOver(tp)
-      }
-    }.apply(tp)
-
     /** Returns true if the type arguments of `P` can be determined from `X` */
     def typeArgsTrivial(X: Type, P: AppliedType)(using Context) = inContext(ctx.fresh.setExploreTyperState().setFreshGADTBounds) {
       val AppliedType(tycon, _) = P
@@ -102,27 +75,43 @@ object TypeTestsCasts {
       val tvars = constrained(typeLambda, untpd.EmptyTree, alwaysAddTypeVars = true)._2.map(_.tpe)
       val P1 = tycon.appliedTo(tvars)
 
+      debug.println("before " + ctx.typerState.constraint.show)
       debug.println("P : " + P.show)
       debug.println("P1 : " + P1.show)
       debug.println("X : " + X.show)
 
-      // It does not matter if P1 is not a subtype of X.
+      // It does not matter whether P1 is a subtype of X or not.
       // It just tries to infer type arguments of P1 from X if the value x
       // conforms to the type skeleton pre.F[_]. Then it goes on to check
       // if P1 <: P, which means the type arguments in P are trivial,
       // thus no runtime checks are needed for them.
-      P1 <:< X
+      withMode(Mode.GadtConstraintInference) {
+        // Why not widen type arguments here? Given the following program
+        //
+        //   trait Tree[-T] class Ident[-T] extends Tree[T] def foo1(tree:
+        //   Tree[Int]) = tree.isInstanceOf[Ident[Int]]
+        //
+        // In checking whether the test tree.isInstanceOf[Ident[Int]]
+        // is realizable, we want to constrain Ident[X] <: Tree[Int],
+        // such that we can infer X = Int and Ident[X] <:< Ident[Int].
+        //
+        // If we perform widening, we will get X = Nothing, and we don't have
+        // Ident[X] <:< Ident[Int] any more.
+        TypeComparer.constrainPatternType(P1, X, widenParams = false)
+        debug.println(TypeComparer.explained(_.constrainPatternType(P1, X, widenParams = false)))
+      }
 
       // Maximization of the type means we try to cover all possible values
       // which conform to the skeleton pre.F[_] and X. Then we have to make
       // sure all of them are actually of the type P, which implies that the
       // type arguments in P are trivial (no runtime check needed).
       maximizeType(P1, span, fromScala2x = false)
 
+      debug.println("after " + ctx.typerState.constraint.show)
+
       val res = P1 <:< P
 
       debug.println(TypeComparer.explained(_.isSubType(P1, P)))
-
       debug.println("P1 : " + P1.show)
       debug.println("P1 <:< P = " + res)
 
@@ -140,7 +129,7 @@ object TypeTestsCasts {
           case _                   => recur(defn.AnyType, tpT)
         }
       case tpe: AppliedType     =>
-        X.widen match {
+        X.widenDealias match {
           case OrType(tp1, tp2) =>
             // This case is required to retrofit type inference,
             // which cut constraints in the following two cases:
@@ -151,10 +140,8 @@ object TypeTestsCasts {
           case _ =>
             // always false test warnings are emitted elsewhere
             X.classSymbol.exists && P.classSymbol.exists &&
-              !X.classSymbol.asClass.mayHaveCommonChild(P.classSymbol.asClass) ||
-            // first try without striping type parameters for performance
-            typeArgsTrivial(X, tpe) ||
-            typeArgsTrivial(stripTypeParam(X), tpe)
+              !X.classSymbol.asClass.mayHaveCommonChild(P.classSymbol.asClass)
+            || typeArgsTrivial(X, tpe)
         }
       case AndType(tp1, tp2)    => recur(X, tp1) && recur(X, tp2)
       case OrType(tp1, tp2)     => recur(X, tp1) && recur(X, tp2)
@@ -163,7 +150,7 @@ object TypeTestsCasts {
       case _                    => true
     })
 
-    val res = recur(replaceX(X.widen), replaceP(P))
+    val res = recur(X.widen, replaceP(P))
 
     debug.println(i"checking  ${X.show} isInstanceOf ${P} = $res")
 

compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala

@@ -746,7 +746,7 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
         tpd.Closure(meth, tss => xCheckMacroedOwners(xCheckMacroValidExpr(rhsFn(meth, tss.head.map(withDefaultPos))), meth))
 
       def unapply(tree: Block): Option[(List[ValDef], Term)] = tree match {
-        case Block((ddef @ DefDef(_, TermParamClause(params) :: Nil, _, Some(body))) :: Nil, Closure(meth, _))
+        case Block((ddef @ DefDef(_, tpd.ValDefs(params) :: Nil, _, Some(body))) :: Nil, Closure(meth, _))
         if ddef.symbol == meth.symbol =>
           Some((params, body))
         case _ => None

compiler/test/dotty/tools/dotc/parsing/StringInterpolationPositionTest.scala

@@ -23,8 +23,8 @@ class StringInterpolationPositionTest extends ParserTest {
   def interpolationLiteralPosition: Unit = {
     val t = parseText(program)
     t match {
-      case PackageDef(_, List(TypeDef(_, Template(_, _, _, statements: List[Tree])))) => {
-        val interpolations = statements.collect{ case ValDef(_, _, InterpolatedString(_, int)) => int }
+      case PackageDef(_, List(TypeDef(_, tpl: Template))) => {
+        val interpolations = tpl.body.collect{ case ValDef(_, _, InterpolatedString(_, int)) => int }
         val lits = interpolations.flatten.flatMap {
           case l @ Literal(_) => List(l)
           case Thicket(trees) => trees.collect { case l @ Literal(_) => l }

scaladoc/src/dotty/tools/scaladoc/renderers/WikiDocRenderer.scala

@@ -13,7 +13,7 @@ class DocRender(signatureRenderer: SignatureRenderer)(using DocContext):
     case md: MdNode => renderMarkdown(md)
     case Nil => raw("")
     case Seq(elem: WikiDocElement) => renderElement(elem)
-    case list: Seq[WikiDocElement] => div(list.map(renderElement))
+    case list: Seq[WikiDocElement @unchecked] => div(list.map(renderElement))
 
   private def renderMarkdown(el: MdNode): AppliedTag =
     raw(DocFlexmarkRenderer.render(el)( (link,name) =>

tests/neg-custom-args/isInstanceOf/html.scala

@@ -0,0 +1,18 @@
+object HTML:
+  type AttrArg = AppliedAttr | Seq[AppliedAttr]
+  opaque type AppliedAttr = String
+  opaque type AppliedTag = StringBuilder
+
+  case class Tag(name: String):
+    def apply(attrs: AttrArg*): AppliedTag = {
+      val sb = StringBuilder()
+      sb.append(s"<$name")
+      attrs.filter(_ != Nil).foreach{
+        case s: Seq[AppliedAttr] =>
+          s.foreach(sb.append(" ").append)
+        case s: Seq[Int] => // error
+        case e: AppliedAttr =>
+          sb.append(" ").append(e)
+      }
+      sb
+    }

tests/neg-custom-args/isInstanceOf/i11178.scala

@@ -0,0 +1,39 @@
+trait Box[+T]
+case class Foo[+S](s: S) extends Box[S]
+
+def unwrap2[A](b: Box[A]): A =
+  b match
+  case _: Foo[Int] => 0 // error
+
+object Test1 {
+  // Invariant case, OK
+  sealed trait Bar[A]
+
+  def test[A](bar: Bar[A]) =
+    bar match {
+      case _: Bar[Boolean] => ??? // error
+      case _ => ???
+    }
+}
+
+object Test2 {
+  // Covariant case
+  sealed trait Bar[+A]
+
+  def test[A](bar: Bar[A]) =
+    bar match {
+      case _: Bar[Boolean] => ??? // error
+      case _ => ???
+    }
+}
+
+object Test3 {
+  // Contravariant case
+  sealed trait Bar[-A]
+
+  def test[A](bar: Bar[A]) =
+    bar match {
+      case _: Bar[Boolean] => ??? // error
+      case _ => ???
+    }
+}