Improve error position and recovery for bad dollar

scala · Jan 23, 2022 · 6445e24 · 6445e24
1 parent 047779a
commit 6445e24
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/compiler/src/dotty/tools/dotc/parsing/Scanners.scala b/compiler/src/dotty/tools/dotc/parsing/Scanners.scala
@@ -1168,7 +1168,9 @@ object Scanners {
           finishNamedToken(IDENTIFIER, target = next)
         }
         else
-          error("invalid string interpolation: `$$`, `$\"`, `$`ident or `$`BlockExpr expected")
+          error("invalid string interpolation: `$$`, `$\"`, `$`ident or `$`BlockExpr expected", off = charOffset - 2)
+          putChar('$')
+          getStringPart(multiLine)
       }
       else {
         val isUnclosedLiteral = !isUnicodeEscape && (ch == SU || (!multiLine && (ch == CR || ch == LF)))

diff --git a/tests/neg/interpolator-dollar.check b/tests/neg/interpolator-dollar.check
@@ -0,0 +1,4 @@
+-- Error: tests/neg/interpolator-dollar.scala:5:20 ---------------------------------------------------------------------
+5 |  def oops = f"$s%s $<s" // error: invalid string interpolation
+  |                    ^
+  |                    invalid string interpolation: `$$`, `$"`, `$`ident or `$`BlockExpr expected
diff --git a/tests/neg/interpolator-dollar.scala b/tests/neg/interpolator-dollar.scala
@@ -0,0 +1,6 @@
+
+trait T {
+  def s = { println("SSS") ; "hello" }
+  def ok = String.format("%s, %<s", s)
+  def oops = f"$s%s $<s" // error: invalid string interpolation
+}