Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up MiMa #229

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Set up MiMa #229

merged 1 commit into from
Jul 3, 2019

Conversation

dwijnand
Copy link
Member

Closes #162

@dwijnand dwijnand requested a review from szeiger June 28, 2019 15:59
@szeiger
Copy link
Contributor

szeiger commented Jul 2, 2019

I don't see anything here that would run MiMa as part of CI. Is this still missing?

@julienrf
Copy link
Contributor

julienrf commented Jul 2, 2019

I think it comes from the ScalaModulePlugin:

https://github.com/scala/sbt-scala-module/blob/2.x/src/main/scala/ScalaModulePlugin.scala#L201-L204

@dwijnand
Copy link
Member Author

dwijnand commented Jul 2, 2019

Yes, that's right. And I tested it by locally reverting #217 and running test.

@szeiger szeiger merged commit 9dcf657 into scala:master Jul 3, 2019
@dwijnand dwijnand deleted the mima branch July 3, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szeiger szeiger Awaiting requested review from szeiger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary compatibility
3 participants
@dwijnand @szeiger @julienrf