Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile #2139

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Fix compile #2139

merged 1 commit into from
Jul 25, 2021

Conversation

tkawachi
Copy link
Contributor

In scala-library 2.13.6, I confirmed that there are two argument lists, but in https://dotty.epfl.ch/api/scala/collection/immutable/TreeSet.html, it looks like there is only one argument list for the constructor.

I tried with scalaVersion := "3.0.1" then scala-libary 2.13.6 is used. I don't know where there's the updated stdlib.

@SethTisue
Copy link
Member

SethTisue commented Jul 24, 2021

To aid migration, Scala 3.0.x uses the 2.13.6 standard library as-is.

Perhaps it's a Scaladoc bug?

@tkawachi
Copy link
Contributor Author

tkawachi commented Jul 25, 2021

Apparently so. It seems that empty argument lists, regardless of whether they are constructors or functions, are accidentally disappearing from scaladoc.
The following code confirms this.

class C1()(implicit i: Int)
class C2()(using i: Int)

class C {
    def f1()(implicit i: Int) = i
    def f2()(using i: Int) = i

    def f3(s: String)(implicit i: Int) = i
    def f4(s: String)(using i: Int) = i

    def f5()()(using i: Int) = i
}

The HTML generated by scala 3.0.1 looks like:

image

image

reported as scala/scala3#13148

@julienrf
Copy link
Contributor

Thanks for reporting! Yes, that seems to be an issue in Scaladoc, so I’m closing the issue here.

@julienrf julienrf closed this Jul 25, 2021
@julienrf julienrf reopened this Jul 25, 2021
@julienrf julienrf merged commit 7f0e336 into scala:main Jul 25, 2021
@julienrf
Copy link
Contributor

Sorry, I didn’t see that there was an issue in the documentation as well… Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants