Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent updates to less stable pre-release versions #1553

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jul 28, 2020

This prevents updates in the same series where the current and new
versions both contain pre-release identifiers and the new version
contains a pre-release identifier with a smaller order than the
pre-release identifer of the current version. It is prevented since the
new version is considered less stable than the current version. We are
preventing updates to pre-releases of a different series for the same
reason.

An example for an update that is prevented by this change is from
2.1.4.0-RC17 to 2.1.4.0-RC17+1-307f2f6c-SNAPSHOT.

This is a follow-up to #1549.

This prevents updates in the same series where the current and new
versions both contain pre-release identifiers and the new version
contains a pre-release identifier with a smaller order than the
pre-release identifer of the current version. It is prevented since the
new version is considered less stable than the current version. We are
preventing updates to pre-releases of a different series for the same
reason.

An example for an update that is prevented by this change is from
2.1.4.0-RC17 to 2.1.4.0-RC17+1-307f2f6c-SNAPSHOT.

This is a follow-up to #1549.
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1553 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1553      +/-   ##
==========================================
+ Coverage   70.21%   70.25%   +0.03%     
==========================================
  Files         113      113              
  Lines        1783     1785       +2     
  Branches       55       55              
==========================================
+ Hits         1252     1254       +2     
  Misses        531      531              
Impacted Files Coverage Δ
...ain/scala/org/scalasteward/core/data/Version.scala 93.75% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144fc8a...3d67d1b. Read the comment docs.

@fthomas fthomas added this to the 0.7.0 milestone Jul 29, 2020
@fthomas fthomas added the bug Something isn't working label Jul 29, 2020
@fthomas fthomas merged commit c7580e7 into master Jul 29, 2020
@fthomas fthomas deleted the topic/prevent-RC-to-RC-SNAPSHOT branch July 29, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant