Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Version.preReleaseIndex #1552

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Fix Version.preReleaseIndex #1552

merged 3 commits into from
Jul 28, 2020

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jul 27, 2020

... and recognize hashes which are only 6 characters long.

preReleaseIndex reported the wrong index for versions with components
with a length greater than one.

This is a follow-up #1549.

... and recognize hashes which are only 6 characters long.

`preReleaseIndex` reported the wrong index for versions with components
with a length greater than one.

This is a follow-up #1549.
@fthomas fthomas added the bug Something isn't working label Jul 27, 2020
@fthomas fthomas added this to the 0.7.0 milestone Jul 27, 2020
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #1552 into master will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1552      +/-   ##
==========================================
+ Coverage   70.19%   70.21%   +0.02%     
==========================================
  Files         113      113              
  Lines        1778     1783       +5     
  Branches       59       55       -4     
==========================================
+ Hits         1248     1252       +4     
- Misses        530      531       +1     
Impacted Files Coverage Δ
...ain/scala/org/scalasteward/core/data/Version.scala 93.58% <87.50%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c40df...db0a7f9. Read the comment docs.

@fthomas fthomas merged commit 144fc8a into master Jul 28, 2020
@mzuehlke
Copy link
Member

This seems to fix nicely the problems that remained after #1549 👍

@fthomas
Copy link
Member Author

fthomas commented Jul 28, 2020

Right, the only remaining problems are updates like these:

@fthomas fthomas deleted the topic/fix-preReleaseIndex branch July 28, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants