Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark com.nequissimus:sort-imports:36845576 as an invalid version. #1354

Merged

Conversation

mwz
Copy link
Contributor

@mwz mwz commented Mar 3, 2020

It appears that the first version of NeQuissimus/sort-imports scalafix rule was published with an incorrect version back in June 36845576, which is getting picked up by Scala Steward as the latest version. See the following PR beautiful-scala/sbt-scalastyle#13.

Could this version be ignored globally by Scala Steward?

cc @NeQuissimus

@NeQuissimus
Copy link
Contributor

👍 from me. I was not even aware of the artifact :-)

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #1354 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
- Coverage   70.75%   70.70%   -0.05%     
==========================================
  Files         102      102              
  Lines        1559     1560       +1     
  Branches       49       46       -3     
==========================================
  Hits         1103     1103              
- Misses        456      457       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb510d...33d48a9. Read the comment docs.

@fthomas fthomas added this to the 0.6.0 milestone Mar 4, 2020
@fthomas fthomas added the enhancement New feature or request label Mar 4, 2020
Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @mwz!

@fthomas fthomas merged commit 1645c6b into scala-steward-org:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants