-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestion: don't suggest SNAP/SNAPSHOT versions unless I'm already on one #483
Comments
scala-steward inherits this behavior from sbt-updates. If I'm correct it will only suggest 3.1.0-SNAP2 as update for 3.0.x if x contains a hyphen, for example if x = 8-RC2 as it is the case in the linked PR. It won't suggest that update if x consists of digits only. I agree that it is not helpful to suggest PRs that go from RC to SNAPSHOT versions. It should be easy for scala-steward to filter any update where the new version contains |
Ok, I just merged #485 so these PRs should not happen anymore. And btw, thanks for the report Seth! |
no problem, thanks for the prompt patch, that's awesome! |
I'm seeing this with ScalaTest a lot lately
e,.g. if I'm on 3.1.0-SNAP1, then a PR upgrading to 3.1.0-SNAP2 is helpful
but if I'm on 3.0.x, a PR upgrading to 3.1.0-SNAP2 is likelier to be annoying than helpful
real-world example of annoyed maintainer: scala/scala-swing#106
The text was updated successfully, but these errors were encountered: