Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: don't suggest SNAP/SNAPSHOT versions unless I'm already on one #483

Closed
SethTisue opened this issue May 10, 2019 · 3 comments · Fixed by #485
Closed

suggestion: don't suggest SNAP/SNAPSHOT versions unless I'm already on one #483

SethTisue opened this issue May 10, 2019 · 3 comments · Fixed by #485

Comments

@SethTisue
Copy link
Contributor

I'm seeing this with ScalaTest a lot lately

e,.g. if I'm on 3.1.0-SNAP1, then a PR upgrading to 3.1.0-SNAP2 is helpful

but if I'm on 3.0.x, a PR upgrading to 3.1.0-SNAP2 is likelier to be annoying than helpful

real-world example of annoyed maintainer: scala/scala-swing#106

@fthomas
Copy link
Member

fthomas commented May 10, 2019

scala-steward inherits this behavior from sbt-updates. If I'm correct it will only suggest 3.1.0-SNAP2 as update for 3.0.x if x contains a hyphen, for example if x = 8-RC2 as it is the case in the linked PR. It won't suggest that update if x consists of digits only.

I agree that it is not helpful to suggest PRs that go from RC to SNAPSHOT versions. It should be easy for scala-steward to filter any update where the new version contains SNAP but the current version don't.

@fthomas
Copy link
Member

fthomas commented May 10, 2019

Ok, I just merged #485 so these PRs should not happen anymore. And btw, thanks for the report Seth!

@SethTisue
Copy link
Contributor Author

no problem, thanks for the prompt patch, that's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants