[no-master] Enable Scala 2.13.0 in the tools and all the other artifacts. #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered by new warnings emitted by the 2.13.0 compiler, yeah!
It is not possible to cross-compile `@deprecatedName`s without warnings between Scala 2.12- and 2.13+, because: * In 2.12, they require symbol literals as arguments * In 2.13, symbol literals are deprecated Since they were deprecated more than two years ago, and are part of an API that is not used much anyway (JS envs), I believe it is fair to drop the source compatibility in this case.
This is the first version that supports Scala 2.13.0 (and also the latest stable version as of this writing).
gzm0
requested changes
Jun 19, 2019
|
|
||
| // filterInPlace replaces retain | ||
| def filterInPlace(p: (K, V) => Boolean): Unit = { | ||
| // Believe it or not, this is the implementation of `retain` in 2.12.x: |
There was a problem hiding this comment.
Hahahahaha, were you anticipating me complaining :P
There was a problem hiding this comment.
Actually I was anticipating myself looking back at this code and being appalled at the inefficiency of it.
...shared/src/main/scala/org/scalajs/core/tools/linker/frontend/optimizer/GenIncOptimizer.scala
Outdated
Show resolved
Hide resolved
sjrd
force-pushed
the
tools-on-scala-2.13.0
branch
from
b7805c6 to
6eccbef
Compare
sjrd
force-pushed
the
tools-on-scala-2.13.0
branch
from
6eccbef to
868b9a8
Compare
11 tasks
…cts. Partest is not yet enabled in this commit, because a dependency of `partest` 2.13.0, namely `testkit`, was not published. See scala/bug#11529 upstream.
sjrd
force-pushed
the
tools-on-scala-2.13.0
branch
from
868b9a8 to
fd2343e
Compare
gzm0
approved these changes
Jun 20, 2019
|
|
||
| # Bugs | ||
| scala/collection/convert/MapWrapperTest.scala | ||
| # Fails for a BigDecimal range with augmented precision (might be an actual bug) |
There was a problem hiding this comment.
Do we need to file an issue for this at least?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's [no-master] because
@deprecatedNameandscoptcommits are irrelevant in master.