Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement polyfill for JSDOM #17

Merged
merged 4 commits into from
Sep 7, 2021

Conversation

armanbilge
Copy link
Member

Fixes #9. h/t jsdom/jsdom#2729.

@djspiewak
Copy link
Collaborator

LOL!!!!!!!

@djspiewak djspiewak merged commit 0b5e866 into scala-js:main Sep 7, 2021
joshkel added a commit to joshkel/fakeIndexedDB that referenced this pull request Oct 19, 2021
Fixing one test seemed to break another; I'm not certain that IndexedDB's expected timing and order of operations can be made to work within the microtask queue.

Instead, break jsdom's sandbox so that we can use Node.js's setImmediate after all:

- jsdom/jsdom#2729
- scala-js/scala-js-macrotask-executor#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the polyfill for JSDOM
2 participants