Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Element#closest #752

Merged
merged 3 commits into from
Dec 3, 2022
Merged

Add Element#closest #752

merged 3 commits into from
Dec 3, 2022

Conversation

DanielMoss
Copy link
Contributor

@DanielMoss DanielMoss commented Dec 3, 2022

Hi! This just adds a facade. You might spot that when I ran prePR some of the API report formatting changed. I'm not sure why this is, but I'm happy to manually pluck those changes out if you like. (done)

MDN docs.

Copy link
Contributor

@zetashift zetashift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, that formatting thing is something I haven't seen before!

The actual code in Element.scala looks good to go, it's a cool utility helper as well.

@armanbilge armanbilge merged commit f336bd3 into scala-js:main Dec 3, 2022
@DanielMoss DanielMoss deleted the Element#closest branch December 3, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants