Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Element#replaceWith #720

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Add Element#replaceWith #720

merged 3 commits into from
Aug 22, 2022

Conversation

zetashift
Copy link
Contributor

armanbilge
armanbilge reviewed Aug 20, 2022
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just another scaladoc tweak 😅

@armanbilge armanbilge linked an issue Aug 20, 2022 that may be closed by this pull request
Missing basic DOM operation: Element.replaceWith #692
Closed
@armanbilge armanbilge changed the title Resolve #692 - Add Element.replaceWith Add Element#replaceWith Aug 20, 2022
armanbilge
armanbilge approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3/3 🚀

@armanbilge armanbilge merged commit 927ac5d into scala-js:main Aug 22, 2022
@zetashift zetashift deleted the add/#692 branch January 27, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing basic DOM operation: Element.replaceWith
2 participants
@zetashift @armanbilge