Create HTMLDialogElement #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this!! I think the file you added is missing the |
|
Now it should be proper. |
armanbilge
reviewed
Jun 30, 2022
armanbilge
reviewed
Jun 30, 2022
Lasering
force-pushed
the
dialog-element
branch
2 times, most recently
from
15efe76 to
b4fe5a6
Compare
armanbilge
approved these changes
Jun 30, 2022
|
@armanbilge shouldn't a type alias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223.
Coudn't find an example of how overloaded methods are implemented in scala-js-dom. Looked at HTMLElement.focus() but it seems the case where focus receives options was not implemented.
Ran
prePRwithout problems, was expectingprePRto edit/generate files inapi-reports. What is the process to commit changes there?