Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document coding standards and conventions #523

Merged
merged 4 commits into from
Sep 5, 2021
Merged

Document coding standards and conventions #523

merged 4 commits into from
Sep 5, 2021

Conversation

japgolly
Copy link
Contributor

Closes #519

Pending #514

@japgolly
Copy link
Contributor Author

@armanbilge @lihaoyi @sjrd Would you all mind having a review of this?

sjrd
sjrd reviewed Aug 30, 2021
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@armanbilge armanbilge mentioned this pull request Aug 30, 2021
Open
@armanbilge armanbilge self-requested a review August 30, 2021 16:16
armanbilge
armanbilge reviewed Sep 1, 2021
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@japgolly
Copy link
Contributor Author

japgolly commented Sep 3, 2021

Addressed PR feedback. Just need to sort out packages in #545

@armanbilge armanbilge added this to the v2.0.0 milestone Sep 4, 2021
@japgolly japgolly marked this pull request as ready for review September 4, 2021 22:20
@japgolly japgolly requested a review from armanbilge September 4, 2021 22:20
@japgolly
Copy link
Contributor Author

japgolly commented Sep 4, 2021

Ok this should be good to go now, @armanbilge can you please give this a final review and hopefully a merge :)

@armanbilge armanbilge mentioned this pull request Sep 4, 2021
Closed
armanbilge
armanbilge reviewed Sep 4, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
armanbilge
armanbilge reviewed Sep 4, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
armanbilge
armanbilge requested changes Sep 4, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is a moving target with all the other changes/decisions going on 🎯 I'll write up a friendly intro to add to this :)

armanbilge
armanbilge reviewed Sep 4, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
armanbilge
armanbilge approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@japgolly I pushed my changes here. Apologies, for expediency I'm going to merge pro-actively (hope it's okay) so that I can make a call for PRs and point to this guide. Please review when you next have a chance!

@armanbilge armanbilge merged commit da70c22 into master Sep 5, 2021
@japgolly japgolly deleted the topic/standards branch September 5, 2021 01:23
@japgolly
Copy link
Contributor Author

japgolly commented Sep 5, 2021

Fantastic additions!! Very nice!!

@armanbilge armanbilge mentioned this pull request Oct 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

@sjrd sjrd sjrd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Document coding standards and conventions
3 participants
@japgolly @sjrd @armanbilge