Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(idb): Update to newer API #350

Merged
merged 3 commits into from
Sep 3, 2021
Merged

feat(idb): Update to newer API #350

merged 3 commits into from
Sep 3, 2021

Conversation

mprevel
Copy link
Contributor

@mprevel mprevel commented Mar 18, 2019

IDB DomString constants have been removed from browser API and replaced by raw String values.

Remove IDB DOMString constants that are no more supported and lead to an UndefinedBehaviorError.
Add these constants in a typesafe way.

armanbilge
armanbilge reviewed Aug 8, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a quick glance, this one looks like it may not be binary compatible. Aside: we should add MiMa to the build if possible.

@armanbilge armanbilge changed the base branch from master to series/1.x August 10, 2021 01:23
@japgolly japgolly marked this pull request as draft August 12, 2021 23:54
@japgolly japgolly marked this pull request as ready for review August 13, 2021 00:15
@japgolly japgolly added this to the v1.2.0 milestone Aug 13, 2021
sjrd
sjrd reviewed Aug 13, 2021
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 1.x, you can introduce the new defs and top-level members, but you cannot remove the old ones. You have to deprecate them instead.

src/main/scala/org/scalajs/dom/raw/Idb.scala Outdated Show resolved Hide resolved
@japgolly
Copy link
Contributor

@armanbilge I'm thinking to just reschedule this to 2.0 rather than try to massage compatibility. wdyt?

@armanbilge
Copy link
Member

Yup, agree!

@armanbilge armanbilge changed the base branch from series/1.x to master August 19, 2021 23:59
@japgolly japgolly modified the milestones: v1.2.0, v2.0.0 Aug 20, 2021
@japgolly
Copy link
Contributor

rebased

mprevel and others added 3 commits September 3, 2021 10:53
@mprevel @japgolly
feat(idb): Update to newer API
095fc7e 
IDB DomString constants have been removed from browser API and replaced by raw String values.

Remove IDB DOMString constants that are no more supported and lead to an UndefinedBehaviorError.
Add these constants in a typesafe way.
@japgolly
Fix compilation
0106f60
@japgolly
Run sbt prePR
f291351
@japgolly japgolly self-assigned this Sep 3, 2021
@japgolly japgolly merged commit c7a8a26 into scala-js:master Sep 3, 2021
@japgolly
Copy link
Contributor

japgolly commented Sep 3, 2021

Thanks so much for the PR @mprevel and sorry for the big turnaround time in getting this merged.

@mprevel
Copy link
Contributor Author

mprevel commented Sep 4, 2021

I was a bit busy and did not follow what happened to this PR lately.
Thanks for your work on it and for having it merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge left review comments

@sjrd sjrd sjrd left review comments

@japgolly japgolly japgolly approved these changes

Assignees

@japgolly japgolly

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mprevel @japgolly @armanbilge @sjrd