Add moveTo and moveBy to Window #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjrd This is ready. |
anilanar
force-pushed
the
window-move-to-and-move-by
branch
from
e14a50b to
4bb6f16
Compare
armanbilge
approved these changes
Aug 8, 2021
armanbilge
force-pushed
the
window-move-to-and-move-by
branch
from
2966bf6 to
4bb6f16
Compare
Undo addition of CanvasRenderingContext2D.moveBy
japgolly
force-pushed
the
window-move-to-and-move-by
branch
from
4bb6f16 to
0221fc0
Compare
|
Thanks for your contribution @anilanar and sorry it took so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the previous PR, it was hastily made.
I also used Int as arguments type for window position related functions (in line with https://github.com/purescript-web/purescript-web-html API). Window positions are integers across all operating systems.
Maybe you can keep this PR open and I can add other missing functions and properties? I'm going through them right now.