Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: C library definitions should allow naming overrides based on platform #114

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

markehammons
Copy link
Collaborator

Fixes #91

@markehammons markehammons force-pushed the markehammons/issue91 branch from 3603ae3 to 227a221 Compare March 25, 2023 15:36
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Merging #114 (227a221) into master (9402f52) will increase coverage by 1.07%.
The diff coverage is 82.35%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   57.43%   58.50%   +1.07%     
==========================================
  Files          64       65       +1     
  Lines        1689     1704      +15     
  Branches       25       25              
==========================================
+ Hits          970      997      +27     
+ Misses        719      707      -12     
Flag Coverage Δ
unittests 58.50% <82.35%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/fr/hammons/slinc/CFunctionBindingGenerator.scala 94.00% <ø> (ø)
...fr/hammons/slinc/CFunctionRuntimeInformation.scala 0.00% <ø> (ø)
core/src/fr/hammons/slinc/FunctionDescriptor.scala 46.51% <ø> (-1.11%) ⬇️
...rc/fr/hammons/slinc/annotations/NameOverride.scala 72.72% <72.72%> (ø)
...ore/src/fr/hammons/slinc/CFunctionDescriptor.scala 100.00% <100.00%> (ø)
j17/src/fr/hammons/slinc/modules/LibModule17.scala 85.71% <100.00%> (ø)
j19/src/fr/hammons/slinc/modules/LibModule19.scala 85.71% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@markehammons markehammons merged commit 50de1f4 into master Mar 25, 2023
@markehammons markehammons deleted the markehammons/issue91 branch March 25, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C library definitions should allow naming overrides based on platform
2 participants