Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Scala 2.13.0-M5 #272

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

Sciss
Copy link
Contributor

@Sciss Sciss commented Jan 31, 2019

  • add to cross-versions
  • update dependencies as necessary
  • some code clean up (explicit return types in public methods, no
    procedure syntax, return types for implicit values)

If you merge this, could you please publish it as v0.2.7 - especially to have an artifact for Scala 2.13.0-M5. Thanks

- add to cross-versions
- update dependencies as necessary
- some code clean up (explicit return types in public methods, no
procedure syntax, return types for implicit values)
Copy link
Contributor

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know my way around this repo, but fwiw, the diffs LGTM

@SethTisue
Copy link
Contributor

I'm noticing, just now, that there is no Travis-CI build in this repo — opened #274 on that

but I verified locally that +test passes on this PR

@godenji godenji merged commit d722d18 into scala-ide:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants