Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight when the Vacuum is in Error State. #281

Closed
sca075 opened this issue Nov 27, 2024 · 14 comments · Fixed by #280 or #289
Closed

Highlight when the Vacuum is in Error State. #281

sca075 opened this issue Nov 27, 2024 · 14 comments · Fixed by #280 or #289
Assignees
Labels
enhancement New feature or request

Comments

@sca075
Copy link
Owner

sca075 commented Nov 27, 2024

Description

Reported from @carefulcomputer on Show error in card when vacuum gets stuck or runs into error

Solution

Few suggestions to make it even better (not sure what all is possible)

Provide a slight red tint to whole image (which would indicate the error)
If possible draw a circle or replace robot icon (or enlarge, different color etc) to make location of robot more prominent

Alternatives

No response

Context

Description
Currently when vacuum gets stuck , the card doesn't show any error. So it is hard to know that it got stuck.

Solution
It will be nice for card to show the error and last known position prominently. That will allow for quick rescue of the bot

@sca075 sca075 added the enhancement New feature or request label Nov 27, 2024
@sca075 sca075 self-assigned this Nov 27, 2024
@sca075 sca075 linked a pull request Nov 27, 2024 that will close this issue
@sca075
Copy link
Owner Author

sca075 commented Nov 27, 2024

The camera can auto export a snapshot of the image when the vacuum state is "error". A notification can be trigger via Home Assistant automations or scenes. When the error is detected the integration is going to provide also the event to home assistant "valetudo_error":

event_type: valetudo_error
data:
  entity_id: vacuum.silenttepidstinkbug
  error: "{error}"
origin: LOCAL
time_fired: "2024-11-26T18:32:39.959478+00:00"
context:
  id: 01JDMVYE8QJE9RHAMXDPWN4Z5J
  parent_id: null
  user_id: null

The robot outer borders colours will change to RED as advised in order to highlight the error condition.

@sca075
Copy link
Owner Author

sca075 commented Nov 27, 2024

preview of error state, robot Outlines.

Screenshot 2024-11-27 at 21 44 20

@carefulcomputer
Copy link

Anyway to make it more prominent ? I think if the rooms are colored, then it may not be super visible. How about filling whole robot with red color ?

Another minor unrelated nit (maybe I should open another issue), in my map, the vacuum icon is flipped (i.e. the lidar is on other side). this is how it looks like when docked (see that lidar dot is facing away from dock)
image

@sca075
Copy link
Owner Author

sca075 commented Nov 28, 2024

@carefulcomputer the lidar (dot) in case of official Valetudo by default (hard coded) is rotating 180 deg. as the V1 for example when is docked is reporting the wrong angle.. to make it short no need and thanks again for reporting that in some other vacuums the angle at dock data are correctly reported.. will add an option (rotate 180 at dock) in the image options that should solve the "details" you highlighted. Fell free to add this enhancement issue for tracking (I can do it later after work for you).

About making the more prominent as it is just an indication and the real point is to be notified that there is an error during cleaning.. it is possible to create a script to save a snapshot and send it to the mobile when you use the HA app. triggered from the event or even the vacuum state.. I will later update the docs and post the script (that I think should work also for you) that will do this. Is that okay for you?

I'm going to covert this to a discussion so that we can keep chat here in a more visible way 😄 okay?

Thanks once again for your contribution here.

@carefulcomputer
Copy link

the reason I am requesting the bot image to be more prominent is, when robot gets stuck somewhere in house, it takes extra time to find the bot. If the map shows the last location prominently then it will be easy to go and pick up the bot.

@sca075
Copy link
Owner Author

sca075 commented Nov 29, 2024

the reason I am requesting the bot image to be more prominent is, when robot gets stuck somewhere in house, it takes extra time to find the bot. If the map shows the last location prominently then it will be easy to go and pick up the bot.

Well the last image is where the vacuum stuck in general should be easy to find it, as well if you enable the automatic snapshots the last image will be in the www folder of home assistant. If you have a look in the docs there is also a script to send the notification via mobile app.

@carefulcomputer
Copy link

carefulcomputer commented Nov 29, 2024

@sca075 , i agree that last image shows the location. My suggestion slightly different. I am requesting to just make the robot icon/color more prominent (vs. just drawing the red outline ). One example would be to infill the robot icon with another shade of red.

@sca075
Copy link
Owner Author

sca075 commented Nov 29, 2024

@carefulcomputer Well.. also if there's no technical reason for this... can do it.. but.. then actually for what reason?

There are a lot of way to detect when the vacuum is in trouble, status text, automations that can easily trigger either by event or state of the vacuum.. notifications with the snapshot. Last recorded position is the actual the last image..

But okay can do that the vacuum get Red .. slightly let's say 70%.. to emphasis the error condition.

@sca075
Copy link
Owner Author

sca075 commented Dec 1, 2024

@carefulcomputer
Screenshot 2024-12-01 at 09 20 43
better? in the next beta this will be available 👌

@sca075
Copy link
Owner Author

sca075 commented Dec 1, 2024

mmm a side point from my side is.. I noticed that you stared and then remove the start from this project.. is there any reason for this? If you start the project this helps me to gain a little more confidence.. for instance help the project to grow also for HACS statistics.. and honestly.. to let me know if I'm doing the right things or not..
Star or not anyhow.. you are very welcome at any time to comment, contribute as you did with new ideas.. and for this thanks a lot.

@sca075 sca075 linked a pull request Dec 1, 2024 that will close this issue
@carefulcomputer
Copy link

@sca075 , it must have been a mistake to unstar it. i love this project and the contributors , like you who are highly responsive. just starred it and made sure that it sticks. :)
i see the new icon, i was recommending something like this. this preserves the vacuum look.
something like this
image

or
image

@carefulcomputer
Copy link

another version
Untitled design

@carefulcomputer
Copy link

another one. pick the one you like.
Untitled design (1)

@sca075
Copy link
Owner Author

sca075 commented Dec 1, 2024

Will change the outline to black before the next beta, it looks much better like you drew it 😉👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants