sc2: fix containerd toml population #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
force-pushed
the
containerd-config-fix
branch
2 times, most recently
from
0baabe4 to
0ccf4fb
Compare
csegarragonz
force-pushed
the
containerd-config-fix
branch
from
0ccf4fb to
276f870
Compare
csegarragonz
force-pushed
the
containerd-config-fix
branch
from
f14e731 to
5af9237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the CoCo operator does modifications to the
containerdconfig file (in/etc/containerd/config.toml) after all runtime classes have been created.This creates a race condition on the config file, as we only wait for the runtime classes to be created, and then proceed to install our local container registry, which in turn also modifies the config file.
This bug was very hard to find, and involved running at the same time:
inotifywait -m -r /etc/containerd/and the deployment script with a--debugflag. Also, for some reason it only appeared consistently in the TDX server, but not on the SNP one.In the process, I make more robust other parts of the code that could also be leading to race conditions or errors, particularly after crashed deployments.
Fixes #119
Fixes #122