Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings for deprecated shell commands #405

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Conversation

cgewecke
Copy link
Member

Ex:

$ testrpc-sc

Screen Shot 2019-09-18 at 9 07 46 PM

$ solidity-coverage

Screen Shot 2019-09-18 at 9 08 19 PM

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (truffle-plugin@b6af63d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##             truffle-plugin     #405   +/-   ##
=================================================
  Coverage                  ?   96.83%           
=================================================
  Files                     ?       13           
  Lines                     ?      631           
  Branches                  ?        0           
=================================================
  Hits                      ?      611           
  Misses                    ?       20           
  Partials                  ?        0
Impacted Files Coverage Δ
lib/ui.js 100% <ø> (ø)
dist/bin.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6af63d...cdf4f85. Read the comment docs.

@cgewecke cgewecke merged commit 37b54cc into truffle-plugin Sep 19, 2019
@cgewecke cgewecke deleted the add/bin-warnings branch September 19, 2019 04:36
@yxliang01
Copy link
Contributor

yxliang01 commented Sep 19, 2019

@cgewecke Want to add https:// to the URL? :)

@cgewecke
Copy link
Member Author

@yxliang01 When I copy paste the unprefixed url into the browser it resolves automatically. And looks cleaner/simpler to me, idk.

Open to persuasion though.

@yxliang01
Copy link
Contributor

@cgewecke What if in different browser or directly clicking on the link? Under that case, I believe it depends on the default protocol of the related software (potentially, terminal emulator + browser). So far, for the links I normally see in CLI, I would see them prefixed with https:// , but not a big issue also I guess.

@cgewecke
Copy link
Member Author

@yxliang01 Yes you're right about this - no one else omits the protocol. Will fix.

cgewecke added a commit that referenced this pull request Sep 25, 2019
* Add ghost-testrpc `0.0.2` dep (mocks $ testrpc-sc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants