Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route all errors through reporter #399

Merged
merged 5 commits into from
Sep 15, 2019
Merged

Conversation

cgewecke
Copy link
Member

PR:

  • Re-organizes and cleans up the truffle plugin
  • Makes UI an extensible class. Separates plugin / app error reporting
  • Adds error handling for .solcover.js load failures (syntex error, etc)
  • Adds cli flags to force use globally installed truffle and plugin supplied truffle lib
  • Adds fallback truffle lib bundle map file (was throwing a transformation error)
  • Routes all errors through the UI class and adds tests for:
    • lib location forcing flags
    • instrumentation errors
    • lib module load errors
    • missing sources folder errors
    • solcover loading errors

@codecov-io
Copy link

Codecov Report

Merging #399 into truffle-plugin will increase coverage by 3.36%.
The diff coverage is 95.6%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           truffle-plugin     #399      +/-   ##
==================================================
+ Coverage           92.61%   95.98%   +3.36%     
==================================================
  Files                  10       11       +1     
  Lines                 542      573      +31     
==================================================
+ Hits                  502      550      +48     
+ Misses                 40       23      -17
Impacted Files Coverage Δ
dist/plugin-assets/truffle.ui.js 100% <100%> (ø)
dist/truffle.plugin.js 100% <100%> (+14.1%) ⬆️
lib/ui.js 100% <100%> (+18.18%) ⬆️
lib/app.js 93.91% <87.87%> (+2.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901430d...b78b31d. Read the comment docs.

@cgewecke cgewecke merged commit c25697d into truffle-plugin Sep 15, 2019
@cgewecke cgewecke deleted the reorg/truffle-plugin branch September 15, 2019 04:15
cgewecke added a commit that referenced this pull request Sep 25, 2019
* Decouple app & plugin UIs. Make UI extensible class consumed by plugin.

* Add flags to force loading truffle lib module from different sources (global, plugin)  

* Route all error output through UI Class 

* Add error checking for solcover.js loading 

* Add truffle lib bundle map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants