Performance improvements experiment #397
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was an attempt to address an unexpected performance slowdown relative to 0.6.x (which sync writes each instrumentation event to file at the vm and should be much slower than an in-memory approach).
Tried:
--max-old-space-size=4096
in combination with memdownThere's some (inconclusive) variance run-to-run but overall it seems that in-process is just slower than stand-alone.
Benchmarking was vs. zeppelin in these workflows. Results ranged from 30 - 100% slowdown relative to a non-coverage test run using a separately launched client.
Each run compared three jobs (~2200 unit tests) (from fast to slow):
Closing for now....