Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop injecting coverage hash fn definition in interfaces #383

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Sep 6, 2019

Instrumenting interfaces triggers an error like this:

,/contracts/standards/ERC900.sol:6:1: TypeError: Functions in interfaces cannot have an implementation.
function coverage_0xdcb93d1c(bytes32 c__0xdcb93d1c) public pure {}
^----------------------------------------------------------------^
,/contracts/standards/ERC900.sol:6:1: TypeError: Functions in interfaces must be declared external.
function coverage_0xdcb93d1c(bytes32 c__0xdcb93d1c) public pure {}
^----------------------------------------------------------------^

Also adds interface test

@codecov-io
Copy link

Codecov Report

Merging #383 into truffle-plugin will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           truffle-plugin     #383      +/-   ##
==================================================
+ Coverage           94.33%   94.34%   +0.01%     
==================================================
  Files                   9        9              
  Lines                 459      460       +1     
==================================================
+ Hits                  433      434       +1     
  Misses                 26       26
Impacted Files Coverage Δ
lib/parse.js 86.9% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bbf10...5d01e7a. Read the comment docs.

@cgewecke cgewecke merged commit ccb7bcf into truffle-plugin Sep 6, 2019
@cgewecke cgewecke deleted the fix/interface-instrumentation branch September 6, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants