Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config option forceParse and replaced absolute paths with relative paths #302

Closed
wants to merge 3 commits into from

Conversation

maxsam4
Copy link
Contributor

@maxsam4 maxsam4 commented Oct 10, 2018

Fixes #301
Fixes #300

@codecov-io
Copy link

codecov-io commented Oct 10, 2018

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files           6        6           
  Lines         368      368           
  Branches       84       84           
=======================================
  Hits          351      351           
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194b336...a6921aa. Read the comment docs.

@maxsam4
Copy link
Contributor Author

maxsam4 commented Jan 4, 2019

btw This also improves the fix applied to #238 by allowing users to forceParse troublesome files.

Copy link

@pedrobranco pedrobranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxsam4 Please define the new option in the README file.

@cgewecke
Copy link
Member

cgewecke commented Oct 13, 2019

Thanks @maxsam4 for doing this...very sorry it did not receive the prompt review it deserved.

Am going to close for house-keeping. In 0.7.0-beta, SC has been redesigned so that dependencies no longer need to be instrumented. And the hardcoded paths written to solidity files have been replace with 32 byte hashes which are read off the VM stack directly from ganache. That work is all being staged on the beta branch / published at the beta tag.

npm install --save-dev solidity-coverage@beta

Closing in favor of #372

@cgewecke cgewecke closed this Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config option 'forceParse' Using relative paths rather than absolute
4 participants