This repository has been archived by the owner on Nov 15, 2020. It is now read-only.
Move plotva #35
Merged
Move plotva #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed for unicode filling throw adb
clicman
suggested changes
Mar 10, 2017
| webElement.clear(); | ||
| webElement.sendKeys(text); | ||
|
|
||
| if (PageFactory.getEnvironment() == Environment.WEB) { |
| import org.slf4j.LoggerFactory; | ||
| import ru.sbtqa.tag.pagefactory.drivers.TagMobileDriver; | ||
|
|
||
| public class MobileConsole { |
There was a problem hiding this comment.
AdbConsole. Because when we will add Iphone it will confuse everything. Also you can describe the interface which will abstract you from mobile platform.
0I0u3uk
suggested changes
Mar 10, 2017
| public static boolean execute(String deviceUDID, String command) { | ||
| ProcessBuilder processBuilder = new ProcessBuilder(new String[]{"adb", "-s", deviceUDID, "shell", command}); | ||
| LOG.info("Command '{}' is processing...", command); | ||
| Process process; |
There was a problem hiding this comment.
Why are here? Why are not 27 line?
| if (PageFactory.getEnvironment() == Environment.MOBILE && TagMobileDriver.getAppiumClickAdb()) { | ||
| int x = webElement.getLocation().getX() + webElement.getSize().getWidth() / 2; | ||
| int y = webElement.getLocation().getY() + webElement.getSize().getHeight() / 2; | ||
| AdbConsole.execute(String.format("input tap %s %s", x, y)); |
There was a problem hiding this comment.
Maybe add description for this things? Because i don't understand what is it :)
0I0u3uk
approved these changes
Mar 10, 2017
clicman
approved these changes
Mar 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25