mobile support #21

kosteman · 2017-02-10T08:06:10Z

No description provided.

Conflicts: pom.xml

Conflicts: pom.xml src/main/java/ru/sbtqa/tag/pagefactory/Page.java

LFing generic step defs

Conflicts: src/main/java/ru/sbtqa/tag/pagefactory/DriverExtensions.java src/main/java/ru/sbtqa/tag/pagefactory/Page.java src/main/java/ru/sbtqa/tag/pagefactory/PageFactory.java src/main/java/ru/sbtqa/tag/pagefactory/PageShell.java src/main/java/ru/sbtqa/tag/pagefactory/aspects/ClickAspect.java src/main/java/ru/sbtqa/tag/pagefactory/stepdefs/GenericStepDefs.java src/main/java/ru/sbtqa/tag/pagefactory/stepdefs/SetupDefsBase.java src/main/java/ru/sbtqa/tag/pagefactory/support/ScreenShooter.java

Conflicts: pom.xml src/main/java/ru/sbtqa/tag/pagefactory/Page.java src/main/java/ru/sbtqa/tag/pagefactory/PageFactory.java src/main/java/ru/sbtqa/tag/pagefactory/PageWrapper.java

Conflicts: src/main/java/ru/sbtqa/tag/pagefactory/DriverExtensions.java src/main/java/ru/sbtqa/tag/pagefactory/Page.java src/main/java/ru/sbtqa/tag/pagefactory/PageFactory.java src/main/java/ru/sbtqa/tag/pagefactory/stepdefs/GenericStepDefs.java src/main/java/ru/sbtqa/tag/pagefactory/stepdefs/SetupDefsBase.java

clicman · 2017-02-10T08:20:53Z

src/main/java/ru/sbtqa/tag/pagefactory/PageFactory.java

+
+    public static Environment getEnvironment() {
+        switch (ENVIRONMENT) {
+            case "web":


В константы: WEB_ENVIRONMENT и MOBILE_ENVIRONMENT

clicman · 2017-02-10T08:24:03Z

src/main/java/ru/sbtqa/tag/pagefactory/aspects/ClickAspect.java

        WebElement targetWebElement;
-        Class<? extends Page> elementRedirect;
+        TypifiedElement typifiedElement;


Do not declare it. It used in one place only.

clicman · 2017-02-10T08:25:30Z

src/main/java/ru/sbtqa/tag/pagefactory/drivers/TagMobileDriver.java

+	}
+
+	setAspectsDisabled(true);
+	LOG.info("Aspect disabled");


There is no need to log this, since it always disabled for mobile. Or move it into DEBUG level. Useless information for user

clicman · 2017-02-10T08:27:00Z

src/main/java/ru/sbtqa/tag/pagefactory/drivers/TagWebDriver.java

+    private static WebDriver webDriver;
+    private static final int ATTEMPTS_TO_START_WEBDRIVER = Integer.parseInt(Props.get("driver.create.attempts", "3"));
+    private static BrowserMobProxy proxy;
+    private static final String WEBDRIVER_PATH = "src/test/resources/webdrivers/";


This path must support configuration from props. Or it should possible to not set it. By default selenium looks it from $PATH

This is the legacy. Will not be fixed in this issue.

clicman · 2017-02-10T08:27:21Z

src/main/java/ru/sbtqa/tag/pagefactory/drivers/TagWebDriver.java

+                } catch (UnreachableBrowserException e) {
+                    log.warn("Failed to create web driver. Attempt number {}", i, e);
+                    if (null != webDriver) {
+                        // Don't dispose when driver is already null, cus it causes new driver creation at Init.getWebDriver()


clicman · 2017-02-10T08:27:51Z

src/main/java/ru/sbtqa/tag/pagefactory/drivers/TagWebDriver.java

+                capabilities.setCapability(CapabilityType.PROXY, seleniumProxy);
+            }
+            switch (PageFactory.getBrowserName()) {
+                case "Firefox":


Add support for marionette and EDGE driver

Will not be fixed in this issue.

clicman · 2017-02-10T08:28:41Z

src/main/java/ru/sbtqa/tag/pagefactory/drivers/TagWebDriver.java

+            log.warn("Failed to quit web driver", e);
+        } finally {
+            try {
+                //TODO take out into a separate method


Complete TODO

This is the legacy. Will not be fixed in this issue.

clicman · 2017-02-10T08:33:16Z

src/main/java/ru/sbtqa/tag/pagefactory/extensions/DriverExtension.java

+     */
+    public static void waitUntilPagePrepared(WebElement webElement) {
+        try {
+            new WebDriverWait(PageFactory.getDriver(), PageFactory.getTimeOutInSeconds() / 2).


Why you divide by 2 here?

This is the legacy. Will not be fixed in this issue.

clicman · 2017-02-10T08:40:44Z

src/main/java/ru/sbtqa/tag/pagefactory/extensions/WebExtension.java

+     *
+     * @param sec a int.
+     */
+    private static void sleep(int sec) {


Duplicated code, whu not generalize it for public use in utils?

This is the legacy. Will not be fixed in this issue.

clicman · 2017-02-10T08:42:03Z

src/main/java/ru/sbtqa/tag/pagefactory/stepdefs/SetupStepDefs.java


-    private static final Logger LOG = LoggerFactory.getLogger(SetupDefsBase.class);
+    private static final Logger log = LoggerFactory.getLogger(SetupStepDefs.class);


kosteman · 2017-02-13T09:11:43Z

Need to add application.properties-sample!

iamanikeev · 2017-02-13T09:40:55Z

src/main/java/ru/sbtqa/tag/pagefactory/drivers/TagWebDriver.java

+    private static void createDriver() throws UnsupportedBrowserException {
+        DesiredCapabilities capabilities = new DesiredCapabilitiesParser().parse();
+
+        if (Props.get("webdriver.remote.host").isEmpty()) {


Two swich-cases with almost duplicate code. I'd merge them into one switch, and set driver in each case if Props.get("webdriver.remote.host").isEmpty() && !Props.get("proxy.enable").isEmpty()

ok, this is legacy, I see

iamanikeev · 2017-02-13T09:49:33Z

src/main/java/ru/sbtqa/tag/pagefactory/drivers/TagWebDriver.java

+        webDriver.get(PageFactory.getInitialUrl());
+    }
+
+    public static void dispose() {


Too many try-catches, and all of them are basically doing the same: log the error message and proceed. Need to simplify this into one big try-catch block, that either catches all the shit in the end, and log all exceptions via e.getMessage(), or just make a try-catch-catch-catch block with different messages.

this is a legacy too. Please, create issues on all of your comments to the legacy code.

iamanikeev · 2017-02-13T09:57:42Z

src/main/java/ru/sbtqa/tag/pagefactory/exceptions/DirectionException.java

@@ -1,12 +1,12 @@
 package ru.sbtqa.tag.pagefactory.exceptions;

-public class GetValueException extends Exception {
+public class DirectionException extends Exception {


Saw it in the methods signature, but couldn't find any place where it is really being thrown. Is it thrown anywhere? I'd leave only SwipeException, it seems enough for me

Fnd please avoid generic exceprion where it possible

This is a bug I agree. I'll remove this exception.

iamanikeev · 2017-02-13T10:05:01Z

src/main/java/ru/sbtqa/tag/pagefactory/exceptions/ElementValueException.java

@@ -0,0 +1,30 @@
+package ru.sbtqa.tag.pagefactory.exceptions;


This exception also looks excess for me. It is being thrown only in one place (WebExtension:32):

if (elementId == null) { throw new ElementValueException("Getting value is not support in element without id"); }

IllegalArgumentException fits well enough here, why not use it?

iamanikeev · 2017-02-13T10:07:07Z

src/main/java/ru/sbtqa/tag/pagefactory/extensions/MobileExtension.java

+		starty = endy = size.height / 2;
+		break;
+	    default:
+		throw new FactoryRuntimeException("Failed to swipe to direction " + direction);


Why not SwipeException ?

Conflicts: pom.xml

kosteman added 28 commits January 17, 2017 14:13

rename page shell to wrapper

7f6ba52

rename step defs

0db6ee6

update pom; add m and w driver classes; fix click aspect

c461531

resolve conflicts and errors

98c121a

Merge remote-tracking branch 'refs/remotes/origin/master'

f3ad7af

Conflicts: pom.xml

revert get pages package

b594a0b

rename drivers; add mobile extensions

e65bba1

split extensions; add swipe

d97e60b

Merge branch 'master'

508949d

Conflicts: pom.xml src/main/java/ru/sbtqa/tag/pagefactory/Page.java

add video recording to mobile driver;

976fbd9

LFing generic step defs

add support screenshot b appium

a5e0088

add appium props; add logs

a38da90

add environment check on driver get

ec7b95b

update dependencies version

f4428cb

change crlf to lf

ee0db14

revert build

0de3f4c

add swipe to text

f18204a

get driver instead of web driver in common extension

5d48557

Merge remote-tracking branch 'refs/remotes/origin/i18n'

1d5ac4d

Conflicts: pom.xml src/main/java/ru/sbtqa/tag/pagefactory/Page.java src/main/java/ru/sbtqa/tag/pagefactory/PageFactory.java src/main/java/ru/sbtqa/tag/pagefactory/PageWrapper.java

revert imports; downgrade to java7 update

2c9cd08

fix pull comments

a36f560

rename log to uppercase

32fa673

add swipe exception throw to step def

cfda0ea

fix i18n dictionaries

8e80da3

fix formating

3196cfa

one more format fix

ed6cb0c

kosteman assigned clicman Feb 10, 2017

kosteman requested a review from clicman February 10, 2017 08:06

kosteman requested review from 0I0u3uk, warorc and iamanikeev February 10, 2017 08:06

clicman suggested changes Feb 10, 2017

View reviewed changes

fix @clicman comments

2cfb2d4

0I0u3uk approved these changes Feb 13, 2017

View reviewed changes

warorc approved these changes Feb 13, 2017

View reviewed changes

iamanikeev suggested changes Feb 13, 2017

View reviewed changes

clicman approved these changes Feb 13, 2017

View reviewed changes

kosteman added 3 commits February 14, 2017 11:34

fix @iamanikeev comments

b35c937

Merge branch 'master'

601f0f0

Conflicts: pom.xml

increase cucumber-runner version to 1.0.2

b3d4438

iamanikeev approved these changes Feb 14, 2017

View reviewed changes

kosteman merged commit 6bf2060 into master Feb 14, 2017

kosteman deleted the mobile-i18n branch February 14, 2017 07:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mobile support #21

mobile support #21

kosteman commented Feb 10, 2017

clicman Feb 10, 2017

clicman Feb 10, 2017

clicman Feb 10, 2017

clicman Feb 10, 2017

kosteman Feb 13, 2017

clicman Feb 10, 2017

clicman Feb 10, 2017

kosteman Feb 13, 2017

clicman Feb 10, 2017

kosteman Feb 13, 2017

clicman Feb 10, 2017

kosteman Feb 13, 2017

clicman Feb 10, 2017

kosteman Feb 13, 2017

clicman Feb 10, 2017

kosteman commented Feb 13, 2017

iamanikeev Feb 13, 2017

iamanikeev Feb 13, 2017

iamanikeev Feb 13, 2017

kosteman Feb 14, 2017

iamanikeev Feb 13, 2017

clicman Feb 13, 2017

kosteman Feb 14, 2017

iamanikeev Feb 13, 2017

iamanikeev Feb 13, 2017


		private static final Logger LOG = LoggerFactory.getLogger(SetupDefsBase.class);
		private static final Logger log = LoggerFactory.getLogger(SetupStepDefs.class);

		@@ -0,0 +1,30 @@
		package ru.sbtqa.tag.pagefactory.exceptions;

mobile support #21

mobile support #21

Conversation

kosteman commented Feb 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kosteman commented Feb 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment