Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid :: and Integer allocation in API hashing #763

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

retronym
Copy link
Member

No description provided.

@retronym retronym force-pushed the faster/api-hash-allocation branch 4 times, most recently from 59d1848 to bd8cd33 Compare April 27, 2020 00:21
Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jvican
Copy link
Member

jvican commented Apr 27, 2020

[error] /home/travis/build/sbt/zinc/internal/zinc-apiinfo/src/main/scala/xsbt/api/HashAPI.scala:148:17: not found: type IterableOnce
689[error]     val tsHash: IterableOnce[Any] = ts match {
690[error]                 ^
691[error] one error found
692[info] Compiling 10 Scala sources to /home/travis/build/sbt/zinc/internal/zinc-apiinfo/target/jvm-2.13/classes ...
693[warn] -Xfuture is deprecated: Not used since 2.13.
694[error] /home/travis/build/sbt/zinc/internal/zinc-apiinfo/src/main/scala/xsbt/api/HashAPI.scala:157:22: type mismatch;
695[error]  found   : Int
696[error]  required: IterableOnce[Any]
697[error]         unorderedHash(new HashIterator(ts.iterator))
698[error]                      ^
699[error] /home/travis/build/sbt/zinc/internal/zinc-apiinfo/src/main/scala/xsbt/api/HashAPI.scala:159:22: type mismatch;
700[error]  found   : Int
701[error]  required: IterableOnce[Any]
702[error]         unorderedHash(ts.toList.map { t =>
703[error]                      ^
704[error] /home/travis/build/sbt/zinc/internal/zinc-apiinfo/src/main/scala/xsbt/api/HashAPI.scala:166:12: type mismatch;
705[error]  found   : IterableOnce[Any]
706[error]  required: xsbt.api.HashAPI.Hash
707[error]     (which expands to)  Int
708[error]     extend(tsHash)
709[error]            ^
710[warn] one warning found
711[error] three errors found

@retronym retronym force-pushed the faster/api-hash-allocation branch from bd8cd33 to 89f1c25 Compare April 29, 2020 11:15
@eed3si9n eed3si9n merged commit 125b3e0 into sbt:develop Apr 29, 2020
@retronym retronym added this to the 1.4.0 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants