Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in scalaCompiler parameter name #368

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Conversation

eed3si9n
Copy link
Member

No description provided.

@jvican
Copy link
Member

jvican commented Jul 16, 2017

I guess this change doesn't have to make it into RC. Parameter names do not influence bincompat, right?

@eed3si9n
Copy link
Member Author

It affects the source compatibility.
It took me a while to figure out why the following wasn't compiling:

      val scalac = ZincUtil.scalaCompiler(
        scalaInstance = scalaInstance.value,
        classpathOptions = classpathOptions.value,
        globalLock = launcher.globalLock,
        componentProvider = app.provider.components,
        secondaryCacheDir = Option(zincDir),
        // This doesn't compile
        dependencyResolution = dependencyResolution.value,
        compilerBridgeSource = scalaCompilerBridgeSource.value,
        scalaJarsTarget = zincDir,
        log = streams.value.log
      )

@jvican
Copy link
Member

jvican commented Jul 16, 2017

Right.

Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eed3si9n eed3si9n merged commit d4d29e8 into sbt:1.0 Jul 17, 2017
@eed3si9n eed3si9n deleted the wip/typo branch July 17, 2017 00:04
@dwijnand
Copy link
Member

Fortunately @deprecatedName is available to change a name without breaking source compatibility.

The sad part is there is no way to make parameter names not part of one's API, in Scala.

@jvican
Copy link
Member

jvican commented Jul 17, 2017

That's pretty cool, didn't know about it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants