Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extra invalidations in initial validation to fix initial compilation error #1284

Merged
merged 6 commits into from
Nov 18, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark another pending unit test as passing
Since comment says "This should compile" and the test expects successful compilation after clean, I guess the incremental compilation is indeed not supposed to fail there?
Friendseeker committed Nov 17, 2023
commit cc9bb528964563dd04fca1800e9655eee6120773
Original file line number Diff line number Diff line change
@@ -3,6 +3,6 @@
$ copy-file changes/Providers.scala Providers.scala
$ copy-file changes/Bar.scala Bar.scala

-> compile # This should compile
> compile # This should compile
> clean
> compile # Make sure that clean compile is fine