Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7288: publish should not fail if publish / skip := true #7295

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Fix #7288: publish should not fail if publish / skip := true #7295

merged 2 commits into from
Jun 13, 2023

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Jun 12, 2023

Also implement the same logic for publishM2.

@adpi2 adpi2 linked an issue Jun 12, 2023 that may be closed by this pull request
Publish with SBT 1.9.0 always requires publishTo defined even with skip/publish set to true #7288
Closed
eed3si9n
eed3si9n approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adpi2!

@eed3si9n eed3si9n changed the title Fix #7288: publish shout not fail if publish / skip := true Fix #7288: publish should not fail if publish / skip := true Jun 12, 2023
@adpi2 adpi2 merged commit f692583 into sbt:1.9.x Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish with SBT 1.9.0 always requires publishTo defined even with skip/publish set to true
2 participants
@adpi2 @eed3si9n