Add library-friendly entrypoint for sbt.ForkMain #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was not possible to use `sbt.ForkMain` as a library since * it called `System.exit`, shutting down the library client JVM process. * it assumed that it was always running in the same classloader as where the test suites it was running causing "class not found: my.test.Suite" if the `ForkMain` class lives in a classloader above the test suite classes. This commit adds a new `main(Array[String],ClassLoader])` entrypoint that allows clients to call `ForkMain` as a library.
|
I don't know if you're open to adding a library endpoint for |
|
The travis CI failure on actions/doc-scala-instance seems unrelated since I am seeing that on other PRs too. |
|
Thank you for merging! I appreciate it 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was not possible to use
sbt.ForkMainas a library sinceSystem.exit, shutting down the library client JVM process.the test suites it was running causing "class not found: my.test.Suite"
if the
ForkMainclass lives in a classloader above the test suiteclasses.
This commit adds a new
main(Array[String],ClassLoader])entrypointthat allows clients to call
ForkMainas a library.