add startScriptArgs setting #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting allows the build to specify a list of arguments to be prepended to the command line arguments of the start script before passing them on to the main class.
| @@ -319,12 +321,13 @@ java %JOPTS% -cp "@CLASSPATH@" "%MAINCLASS%" %* | |||
|
|
|||
| @MAIN_CLASS_SETUP@ | |||
|
|
|||
| exec java $JAVA_OPTS -cp "@CLASSPATH@" "$MAINCLASS" "$@" | |||
| exec java $JAVA_OPTS -cp "@CLASSPATH@" "$MAINCLASS" @ARGS@ "$@" | |||
There was a problem hiding this comment.
since the args are passed through as-is (no quoting), people would have to do any quoting themselves, and separately for linux/mac and windows - should we auto-quote each arg for them? I know how to do that for unix but not Windows. The way we are doing classpath is bogus and doesn't handle backslashes or double quotes in the classpath, though we've gotten away with it so far.
There was a problem hiding this comment.
oh just saw below that you are doing double quotes
|
btw, do we need to coordinate with #40 |
|
fixed the quoting (and a bug) |
|
Any chance of this being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting allows the build to specify a list of arguments to be
prepended to the command line arguments of the start script before
passing them on to the main class.