fix: next with qualifier strategy not incrementing version correctly #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrapyre
force-pushed
the
fix-next-with-qualifier-not-incrementing-version-correctly
branch
from
4de5eaa to
84f53a2
Compare
|
@xuwei-k , it looks like the release for the last PR failed due to the credentials not being properly set. Could you fix and release? Many thanks! |
|
@xuwei-k, I see you're no longer the reviewer for this PR. Could you quickly merge this fix? It covers a bug introduced by your changes in the previous PR, which I had accounted for before the solution was moved to NextStepWithQualifier. Also, it looks like there is a credential error in the release scripting, as version 1.2 was never published. Could you fix as well? Many thanks! |
|
Linking this issue: #394. |
|
Don't change unrelated files! also You should not mention to me with every comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NextWithQualifierstrategy is not currently incrementing the version correctly. This PR updates the default implementation ofreleaseVersionto react to the value ofreleaseVersionBumpwhere the strategy is defined. It also updates the README to reflect these changes.