Avoid sbt-web 1.4.x dependency, use latest 1.5.x #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "problem" is that currently sbt-web 1.4.x is pulled in, but only sbt-web 1.5.+ is hosted on maven central. So when blocking the deprecated repos, I can not build the project:
dependency tree
build.sbt
:dependency tree
project/plugins.sbt
:sbt-web was upgraded to 1.5.x just recently in paradox 0.10.6: lightbend/paradox@80c9c01
However because we want to use paradox 0.9.2 for a 0.7.0 release, it makes sense to override the used sbt-web version to use 1.5.x. Since I maintain sbt-web I can pretty much assure that 1.4.x and 1.5.x are compatible, however the only thing I removed where the
Compat
objects, because sbt 1.5.x does not cross compile to sbt 0.13.x anymore. This was not a problem until now, because I always just changedCompat.cacheStore(streams.value, "...")
tostreams.value.cacheStoreFactory.make("...")
in all the projects I migrated to sbt-web 1.5.x.This PR now fails however because of course paradox 0.9.x still uses that
Compat
object's methods:So we have three choices:
I am against that, because bumping sbt-web 1.4.x to 1.5.x never caused any problems in other projects and sbt 1.5.x did fix problems, like memory leaks, got ride of the akka dependency within sbt (which was a bit... not nice to do that), support for newever npm/node versions etc.
Compat
object, so we can bump to sbt 1.5.x here. However I guarantee you this will never happen. Lightbend does not do that, we asked different things in the last two years to fix for us (like backport the Scala 3 support PR to akka-http 10.2.x, which would not be hard, they didn't do it).Compat
object to a new sbt-web 1.5.4 release so this PR turns green. IMHO this is the easiest thing to do and also a manageable trade off.