Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JDK 21 to CI #119

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add JDK 21 to CI #119

merged 1 commit into from
Jan 26, 2024

Conversation

mdedetrich
Copy link
Collaborator

@mdedetrich mdedetrich commented Jan 24, 2024 •
edited
Loading

Self explanatory

@SethTisue
Copy link
Member

looks like src/sbt-test/sbt-osgi/test-10-multi-project-dependsOn-includePackage-versions/build.sbt: scalaVersion := "2.12.6" needs a version bump

@mdedetrich
Copy link
Collaborator Author

looks like src/sbt-test/sbt-osgi/test-10-multi-project-dependsOn-includePackage-versions/build.sbt: scalaVersion := "2.12.6" needs a version bump

Thanks! I'll do this now

@mdedetrich mdedetrich mentioned this pull request Jan 26, 2024
Merged
@mdedetrich mdedetrich requested a review from SethTisue January 26, 2024 05:57
@mdedetrich
Copy link
Collaborator Author

@SethTisue Thanks for the pickup, this is now fixed

@mdedetrich mdedetrich merged commit 05d385b into sbt:main Jan 26, 2024
14 checks passed
@mdedetrich mdedetrich deleted the add-jdk-21-to-ci branch January 26, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

@eed3si9n eed3si9n Awaiting requested review from eed3si9n

@romainreuillon romainreuillon Awaiting requested review from romainreuillon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdedetrich @SethTisue