Remove sbt 0.13.x support and syntax improvements #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
commented
Jan 24, 2024
| @@ -16,19 +16,20 @@ | |||
|
|
|||
| package com.typesafe.sbt.osgi | |||
|
|
|||
| import java.nio.file.{FileVisitOption, Files, Path} | |||
| import java.nio.file.{ FileVisitOption, Files, Path } | |||
There was a problem hiding this comment.
Imports were messed up in this PR, this fixes it back
mdedetrich
force-pushed
the
remove-sbt-0.13-support-and-syntax-cleanup
branch
from
ed5f11a to
e4bbce0
Compare
|
Why not replace with and delete src/main/scala-sbt-1.0/com/typesafe/sbt/osgi/SbtCompat.scala?Also that line needs to be changed to the newer sbt slash syntax anyway. |
mdedetrich
force-pushed
the
remove-sbt-0.13-support-and-syntax-cleanup
branch
from
e4bbce0 to
7077f08
Compare
|
@mkurz Done, thanks |
|
@mkurz Sorry for pinging you but can you review this PR? I have another fix coming through and I coded it against these changes (see apache/pekko#1039 (comment) for context) and it would be good to get it out soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes sbt 0.13.x support since its ancient, syntax improvements, use sbt slash syntax and also use lazy val's