Setting maintainer for Docker images can be optional. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val fromCommand = Cmd("FROM", dockerBaseImage) | ||
|
|
||
| val maintainerCommand: Option[Cmd] = { | ||
| if (maintainer.size == 0) |
There was a problem hiding this comment.
maintainer.isEmpty is a better choice here
The maintainer line is optional in the Dockerfile. While the initial commit assumed that it was required, it appears that this is not the case. We can therefore skip adding the line if the maintainer is not set.
|
LGTM. |
muuki88
added a commit
that referenced
this pull request
Oct 27, 2014
Setting maintainer for Docker images can be optional.
|
merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maintainer line is optional in the Dockerfile. While the initial commit
assumed that it was required, it appears that this is not the case. We
can therefore skip adding the line if the maintainer is not set.