Merge pull request #524 from myyk/codacy-fixes

Codacy recommended cleanup.
sbt · Mar 17, 2015 · 0d72913 · 0d72913
2 parents 7be0d83 + 18006c4
commit 0d72913
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/main/scala/com/typesafe/sbt/packager/rpm/RpmMetadata.scala b/src/main/scala/com/typesafe/sbt/packager/rpm/RpmMetadata.scala
@@ -18,8 +18,7 @@ case class RpmMetadata(
   summary: String,
   description: String,
   autoprov: String,
-  autoreq: String) {
-}
+  autoreq: String)
 
 /**
  * The Description used to generate an RPM

diff --git a/src/main/scala/com/typesafe/sbt/packager/windows/WixHelper.scala b/src/main/scala/com/typesafe/sbt/packager/windows/WixHelper.scala
@@ -54,7 +54,7 @@ object WixHelper {
     // TODO - First we find directories...
     // Adds all subdirectories... there was a bug when there were directories with only subdirs and no files in the tree,
     // so there was a gap and dirXml failed to create some directories
-    def allParentDirs(f: File): Seq[File] = if (f == null) Seq() else Seq(f) ++ allParentDirs(f.getParentFile)
+    def allParentDirs(f: File): Seq[File] = Option(f).toSeq ++ allParentDirs(f.getParentFile)
     val filenamesPrep =
       for {
         f <- features