Make LicenseDetection.apply public

[alejandrohdezma]

This method is being used in sbt-github and the build is broken when updating to sbt-header v5.8.0.

[hseeberger]

Hey @vasilmkd, could you please review? Is there a reason why the respective apply method taking the end year was added non public?

[vasilmkd]

Hi, in my original change that added support for headerEndYear, I didn't want to impose a new public API on users.

I think you should be free to make it public.

I'm curious to see where the sbt-github build broke, the change #282 should have been source and binary compatible.

[alejandrohdezma]

Hey @vasilmkd the reason was that in sbt-github I was already sending the year range it extracted from GitHub so it got into headers. And now it is failing because "2019-2022".toInt fails. I quickly solved it by inlining the whole implementation for LicensdeDetection.apply. But I would prefer to use the actual method.

[vasilmkd]

Cool, thanks for explaining! I believe the method can be safely exposed publicly.

[hseeberger]

Thanks, guys!