Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate snapshot version properly #170

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Calculate snapshot version properly #170

merged 1 commit into from
Oct 23, 2023

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich force-pushed the calculate-snapshot-version-properly branch from 7730aca to f8ed0c6 Compare October 22, 2023 08:19
@mdedetrich
Copy link
Contributor Author

@eed3si9n If you have the time do you mind quickly reviewing this so we don't have to manually set the snapshot version again when I publish.

eed3si9n
eed3si9n approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n
Copy link
Member

Maybe we should add this code to sbt-dynver itself since all sbt plugins need it.

@mdedetrich
Copy link
Contributor Author

Maybe we should add this code to sbt-dynver itself since all sbt plugins need it.

I can file an issue for it since I can see arguments back and forth on this

@mdedetrich mdedetrich merged commit 693adf3 into sbt:main Oct 23, 2023
7 checks passed
@mdedetrich mdedetrich deleted the calculate-snapshot-version-properly branch October 23, 2023 02:41
@mdedetrich
Copy link
Contributor Author

Maybe we should add this code to sbt-dynver itself since all sbt plugins need it.

@eed3si9n Issue created at sbt/sbt-dynver#277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

@armanbilge armanbilge Awaiting requested review from armanbilge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdedetrich @eed3si9n