Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicize option to disable JGit #230

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

jpassaro
Copy link
Contributor

Add useReadableConsoleGit to autoImport.

Update documentation to explain the default of dual-use JGit and
executable, and how to customize if either one is undesirable.

Add `useReadableConsoleGit` to autoImport.

Update documentation to explain the default of dual-use JGit and
executable, and how to customize if either one is undesirable.
Copy link
Collaborator

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but aside from these looks like a nice improvement, thanks!

README.md Outdated
write operations, it assumes a git executable is present and on the PATH and
it uses that.

In certain circumstances you may want to force the use of JGIT or an
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In certain circumstances you may want to force the use of JGIT or an
In certain circumstances you may want to force the use of JGit or an

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jpassaro
Copy link
Contributor Author

@raboof thank you for the feedback. I think I've addressed it all.

@raboof raboof merged commit b1df0b1 into sbt:main Nov 22, 2022
@raboof
Copy link
Collaborator

raboof commented Nov 22, 2022

Thanks for adding these clarifications!

@jpassaro
Copy link
Contributor Author

jpassaro commented Dec 5, 2022

hi @raboof thank you for merging this. Would you consider putting out a patch or minor release for it?

@raboof
Copy link
Collaborator

raboof commented Dec 5, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants